Code Review Comments of Sprint1

Code Review Comments of Sprint 1 - Line item 1.0 Bug fixes and changes

Review Summary:

• Time: 12 Nov 2009, 2.45 PM - 4.30 PM
• Venue: ConfRoom - Kalyani
• Review Presenter: Suresh, Gayathri
• Reviewers: Ashu, Rohit, Shiv(offline)
• LOC Added:
• LOC Deleted:
• LOC Modified:

Review Comments:

• Change Tag queuing mechanism to discard tags during buffer-overflow in first-in first-out fashion. In API3.10 it was newer tags that were being discarded.As the reader behavior is also changing this way, we will make this change in API3 1.1.
  • Action: Done.
• Recommendation to changed enableAccessReports in TAG_STORAGE_SETTING from boolean to bit-field so as to give explicit control for each access-operation.
  • To keep it simple, lets use boolean. No change.
• Add comments in rfidApiStruct.h for consuming the reserved DWORD
  • Action: Done.
• Reconnect API logic: Fetching of LLRPConfigurationStateValue from Reader for every SET_READER_CONFIG or ADD_RO_SPEC, etc is slowing down the API. Shiv recommended to increment this value locally and synch-up with reader periodically.
  • Action: Whenever Access-spec is added with Non Zero Operation Count Value, synch-up with Reader. Else simply increment in Dll locally. Done.
• How to address backward compatibility for API3 1.0 applications? Applications compiled with API3 1.0 should be able to run seamlessly on API3 1.1 Dll without availing new features [Like expanded reserved fields in Structures and API parameters]
  • Action: Added CONNECTION_INFO structure in RFID_Connect API; reserved field is expanded. This is to allow applications using Dll version 1.0 to be have full backward compatible functionality and newer Applications to get support for newer Dlls. Done.
• GetTagStorageSettings in .NET
  • Action: Done.

Code Review Comments of Sprint 1 - Line item 1.1 Write APIs for specific fields

Review Summary:

• Time: 18 Nov 2009, 11 AM - 12 PM
• Venue: ConfRoom - Darbari
• Review Presenter: Ashu
• Reviewers: Gayathri, Rohit
• LOC Added:
• LOC Deleted:
• LOC Modified:

Review Comments:

• Remove parameter lpAccessFilter from all new APIs
  • Action: Done.

• Parameter validation to be performed after populating structure of type WRITE_ACCESS_PARAMS, so that no modification is required at genericreader level and no new opcodes required in RFID_constants.h.
  • Action: Done.

• defines in rfidapi.cpp to be moved to genericreader.h and all local variables to start with lower case to follow coding conventions
  • Action: Done.

Code Review Comments of Sprint 1 - Line item 1.2 Server Mode API

Review Summary:

• Time: 18 Nov 2009, 11 AM - 12 PM
• Venue: ConfRoom - Darbari
• Review Presenter: Rohit
• Reviewers: Ashu, Gayathri, Suresh (Offline comments on 25 Nov 09)
• LOC Added:
• LOC Deleted:
• LOC Modified:

Review Comments:

• RFID_AcceptReaderConnection(server Mode API )to be renamed as RFID_AcceptConnection.The API parameter timeout to be clubbed into a new structure which should contain another field to input VersionInfo(5.0 or 5.1 etc). The out pReaderHandle parameter should be lined up first in the parameter list.
  • Action: The new API signature is RFID_AcceptConnection(RFID_HANDLE32* pReaderHandle,SOCKET readerSocket,LPSERVER_INFO lpServerInfo,LPVOID null). A new structure SERVER_INFO(*LPSERVER_INFO) has been added.Done.

• The errorcode "RFID_INVALID_SOCKET_PASSED" to be renamed as "RFID_INVALID_SOCKET" and to be defined in the same group as RFID_COMM_OPEN_ERROR.
  • Action: Done.

• The function "acceptConnectionToReader" in ltk_connection.cpp to be renamed as "acceptConnection".
  • Action: Done.

• The dll intialization and retrieval of readercapabilities in CGenericReader::acceptConnection to be moved to a new routine meant to be used in the RFID_Connect and RFID_Reconnect APIs as well.
  • Action: A new routine PostConnectInitialization has been added in CGenericReader Class.Its now being called from the other APIs as suggested.Done.

• The timeout validation,GenericReader initialization to be moved into a new routine meant to be used in the RFID_Connect API as well.
  • Action: A new routine InitializeGenericReader has been added in CGenericReader Class.Its now being called in RFID_Connect as well.Done.

• Do away with the redundant routine IsSocketConnected in CHandleManager class.Update Documentation.
  • Action: Done.

• Update CE C-UnitTesting Interface to test Server Mode API
  • Action: Done.

• Rename "testAcceptConnection" function in C# unit TestApp with testThreadSafetyAcceptConnection
  • Action: Done.

• (Suresh-25th Nov) Initialize-function to be removed and revert back Connect method's implementation in Generic Reader class
  • Action: Done.

• (Suresh-25th Nov) Avoid inclusion of "Winsock2.h" in "rfidapi.h". Define a alternative type for SOCKET to avoid possible break in build when compiled on non-win32 compilers.
  • Action: A newtype SOCKET_HANDLE is defined in "rfidapiTypes.h".

• (Suresh-25th Nov) Avoid including "ATLbase.h" in rfidapi.h"
  • Action: CHAR to TCHAR conversion now done through _stprintf.

Code Review Comments of Sprint 1 - Line item 1.3 AutonoumousMode TagEvents PurgeTags

Review Summary:

• Time: 25 Nov 2009, 4 PM - 5 PM
• Venue: ConfRoom - Cabin 5th Floor
• Review Presenter: Gayathri, Suresh
• Reviewers: Ashu, Rohit
• LOC Added: 907
• LOC Deleted: 1603
• LOC Modified: 235

Review Comments:

• Comment 1
  Code Snippet for RFID_PurgeTags.
• Action: Done.

References

• Back to SDD
• RFIDAPI3 1.1 API Documentation