Code Review Comments of Sprint4

Code Review Comments of Sprint 3 - NXP Custom API Support

Review Summary:

• Time: 13 Jan 2009, 12.15 PM - 1.45 PM
• Venue: ConfRoom - Basant
• Review Presenter: Rohit
• Reviewers: Ashu, Suresh, Gayatri
• LOC Added:
• LOC Deleted:
• LOC Modified:

Review Comments:

• Changes suggested in naming conventions: 1) No prefix of b for Boolean variable 2)prefix ACCESS_NXP to all the new additions of enum type ACCESS_OPERATION_CODE 3)rename EAS of OPERATION_QUALIFIER to EAS_SCAN 4)prefix NXP to all the APIs RFID_SetEAS,RFID_SetQuiet,RFID_ResetQuiet
  • Action: Done.
• Allow ResetQuiet to be added into access-sequence.This will let the user to Keep issuing the reader-level commands for a definite period with a single API call.
  • Done.
• The function "handleNXPEASAlarm" should take a parameter of type " CNXPEASAlarmNotification* " instead of " CParameter* "
  • Action: Done.
• Create a new group for all NXP APIs in C#
  • Action: A new object "NXP Operations" of the type "NXP" was added to "TagAccess" class.Further the definitions of "SetEASParams,SetQuietParams,ResetQuietParams" have been moved to NXP class definition itself.Done.
• Make the function IsCustomOpSpecResult in LLRPFW class inline.
  • Action: Done.
• The parameter validation for "AntennaOpList" in GenericReader class has to be moved into a function.
  • Action: The validation code has been moved to ValidateTriggersInfo function which had been extended to identify whether Inventory or Access API was called.The Validation code uses this information.Done.

References

• Back to SDD
• RFIDAPI3 1.1 API Documentation